feat: add upload cache preflight#379
Conversation
thymikee
force-pushed
the
codex/upload-cache-preflight
branch
from
e5ce14d to
ae54ba6
Compare
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e5ce14dffe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!response.ok) { | ||
| throw new AppError('COMMAND_FAILED', `Upload preflight failed: ${body}`, { | ||
| statusCode: response.status, | ||
| hint: 'Verify the remote daemon artifact upload cache endpoint is available and authorized.', | ||
| }); |
There was a problem hiding this comment.
This makes upload preflight a hard dependency: any non-2xx response now throws and aborts before the regular /upload path is attempted. In real deployments where preflight is partially rolled out or temporarily unhealthy (for example 5xx/403 from an upstream cache/auth layer), artifact uploads that previously worked will now fail even though the upload endpoint is still available. Since preflight is an optimization, this path should degrade to a cache miss and continue with normal upload instead of failing the command.
Useful? React with 👍 / 👎.
thymikee
force-pushed
the
codex/upload-cache-preflight
branch
from
ae54ba6 to
9c58da6
Compare
thymikee
force-pushed
the
codex/upload-cache-preflight
branch
from
9c58da6 to
61bb45c
Compare
1 participant
Summary
Adds automatic SHA-256 upload preflight for file artifacts sent to remote/cloud daemons, returning cached upload IDs without transferring bytes on cache hits.
Keeps
.appdirectory uploads on the existing tar-stream path until app-bundle caching is supported, and adds focused upload-client tests for hit, miss, legacy fallback, and app-bundle behavior.Touched files: 2. Scope stayed within the upload client path.
Validation
pnpm exec oxfmt --write src/upload-client.ts src/__tests__/upload-client.test.tspnpm check:quickpnpm test src/__tests__/upload-client.test.ts